Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix($animator): avoid completing the animation asynchronously unless CSS transtiions/animations are present #4213

Closed
wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Oct 1, 2013

Closes #4023
Closes #3940

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@wizardwerdna
Copy link
Contributor

Well done, and thank you. I agree that its not a problem to expressly flush the $timeout, but its something of a surprise unless you are aware that things like ngClass are animation-aware.

@kevin-smets
Copy link

Ehm, I'm not sure what this means exactly. So now the animations (e.g. on ng-view) no longer run at the same time?

A problem I've been having with this, is that the leaving content on an ng-view gets cloned, but this means it loses it's scroll positions in all the content.

That way you see all content jump up just when the animation starts... Is this another issue? Then I'm sorry, I'll open another issue for that unless this PR fixes that.

@matsko
Copy link
Contributor Author

matsko commented Oct 2, 2013

@kevin-smets no this only means that if there is an animation already on a parent element then it won't asynchronously stop, but instead synchronously stop. It barely effects anything outside of tests and a bug with replace.

Your issue about content jumping most likely has to do with the DOM reordering. Please open a new issue with a plunkr example if possible.

@matsko matsko closed this Oct 2, 2013
@matsko matsko deleted the clean_up_animation_code branch October 2, 2013 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants